Coverity issue fix 35/189335/1 accepted/tizen/unified/20180917.135122 submit/tizen/20180917.063243
authorhj kim <backto.kim@samsung.com>
Mon, 17 Sep 2018 06:23:07 +0000 (15:23 +0900)
committerhj kim <backto.kim@samsung.com>
Mon, 17 Sep 2018 06:23:07 +0000 (15:23 +0900)
Change-Id: I12fdb2170bb01586ccf7974fe20d6e2cfcd51ab0

src/media_controller_db.c
src/media_controller_metadata.c
test/client_test/media_controller_client_test.c

index 945dd61..5b9640b 100755 (executable)
@@ -499,6 +499,7 @@ int mc_db_get_playback_info(void *handle, const char *server_name, mc_playback_h
        _playback = (media_controller_playback_s *)calloc(1, sizeof(media_controller_playback_s));
        if (_playback == NULL) {
                mc_error("OUT_OF_MEMORY");
+               MC_SAFE_FREE(playlist_name);
                MC_SAFE_FREE(index);
                return MEDIA_CONTROLLER_ERROR_OUT_OF_MEMORY;
        }
index f5d7007..a54c8c8 100755 (executable)
@@ -243,7 +243,7 @@ int mc_search_destroy(mc_search_h search)
 
        length = g_list_length(mc_search->search_list);
 
-       for (idx = 0; idx > length; idx++) {
+       for (idx = 0; idx < length; idx++) {
                search_item = (mc_search_item_s*)g_list_nth_data(mc_search->search_list, idx);
 
                if (search_item != NULL) {
index 7761de3..e01c214 100755 (executable)
@@ -209,6 +209,7 @@ void _mc_cmd_reply_received_cb(const char *server_name, const char *request_id,
 
        if (request_id == NULL) {
                mc_error("Invalid request_id");
+               return;
        }
 
        for (i = 0; i < TEST_REQ_MAX; i++) {