ac/llvm: use fmac instead of mul+sub in face culling
authorMarek Olšák <marek.olsak@amd.com>
Fri, 15 Oct 2021 08:48:51 +0000 (04:48 -0400)
committerMarge Bot <eric+marge@anholt.net>
Tue, 19 Oct 2021 12:49:05 +0000 (12:49 +0000)
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13380>

src/amd/llvm/ac_llvm_cull.c

index ad40692..5e7e032 100644 (file)
@@ -92,9 +92,9 @@ static LLVMValueRef ac_cull_face(struct ac_llvm_context *ctx, LLVMValueRef pos[3
    LLVMValueRef det_t1 = LLVMBuildFSub(builder, pos[1][1], pos[0][1], "");
    LLVMValueRef det_t2 = LLVMBuildFSub(builder, pos[0][0], pos[1][0], "");
    LLVMValueRef det_t3 = LLVMBuildFSub(builder, pos[0][1], pos[2][1], "");
-   LLVMValueRef det_p0 = LLVMBuildFMul(builder, det_t0, det_t1, "");
-   LLVMValueRef det_p1 = LLVMBuildFMul(builder, det_t2, det_t3, "");
-   LLVMValueRef det = LLVMBuildFSub(builder, det_p0, det_p1, "");
+   /* t0 * t1 - t2 * t3  =  t2 * -t3 + t0 * t1  =  fma(t2, -t3, t0 * t1) */
+   LLVMValueRef det = ac_build_fmad(ctx, det_t2, LLVMBuildFNeg(builder, det_t3, ""),
+                                    LLVMBuildFMul(builder, det_t0, det_t1, ""));
 
    /* Negative W negates the determinant. */
    det = LLVMBuildSelect(builder, w->w_reflection, LLVMBuildFNeg(builder, det, ""), det, "");