xhci: use the correct define to indicate port status suspend change.
authorMathias Nyman <mathias.nyman@linux.intel.com>
Tue, 24 Nov 2015 11:09:46 +0000 (13:09 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 1 Dec 2015 18:45:51 +0000 (10:45 -0800)
use the variables defined for populating the port status and
port chage bits retuend by GetPortStatus request intead of
the hub class feature selectors.

The defines for hub class feature selectors are used for other purposes,
they work as port status and feature selectors are in the same order, and
set the same bits, but it makes the code very hard to follow

Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/xhci-hub.c

index 0230965..0863d8a 100644 (file)
@@ -820,7 +820,7 @@ static u32 xhci_get_port_status(struct usb_hcd *hcd,
                xhci_hub_report_usb2_link_state(&status, raw_port_status);
        }
        if (bus_state->port_c_suspend & (1 << wIndex))
-               status |= 1 << USB_PORT_FEAT_C_SUSPEND;
+               status |= USB_PORT_STAT_C_SUSPEND << 16;
 
        return status;
 }