selftests/resctrl: Remove unnecessary startptr global from fill_buf
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 17 Jul 2023 13:15:01 +0000 (16:15 +0300)
committerShuah Khan <skhan@linuxfoundation.org>
Tue, 25 Jul 2023 14:53:36 +0000 (08:53 -0600)
fill_buf stores buffer pointer into global variable startptr that is
only used in fill_cache().

Remove startptr as global variable, the local variable in fill_cache()
is enough to keep the pointer.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Tested-by: Babu Moger <babu.moger@amd.com>
Tested-by: Shaopeng Tan (Fujitsu) <tan.shaopeng@fujitsu.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/resctrl/fill_buf.c

index d8f5505..a5ec9c8 100644 (file)
@@ -22,8 +22,6 @@
 #define PAGE_SIZE              (4 * 1024)
 #define MB                     (1024 * 1024)
 
-static unsigned char *startptr;
-
 static void sb(void)
 {
 #if defined(__i386) || defined(__x86_64)
@@ -147,7 +145,6 @@ static int fill_cache(size_t buf_size, int memflush, int op, char *resctrl_val)
        if (!start_ptr)
                return -1;
 
-       startptr = start_ptr;
        end_ptr = start_ptr + buf_size;
 
        /* Flush the memory before using to avoid "cache hot pages" effect */
@@ -159,7 +156,7 @@ static int fill_cache(size_t buf_size, int memflush, int op, char *resctrl_val)
        else
                ret = fill_cache_write(start_ptr, end_ptr, resctrl_val);
 
-       free(startptr);
+       free(start_ptr);
 
        if (ret) {
                printf("\n Error in fill cache read/write...\n");