Skip negative alignment check when alignment is 1
authorMika Isojärvi <misojarvi@google.com>
Fri, 19 Feb 2016 21:59:13 +0000 (13:59 -0800)
committerMika Isojärvi <misojarvi@google.com>
Fri, 19 Feb 2016 21:59:13 +0000 (13:59 -0800)
Skip uniform buffer negative alignment check when alignment is 1 since there
are no possible invalid values.

Bug: 27270184
Change-Id: I33f1b51c312cfe2ecc6ccf0f3b0b994385724b1d

modules/gles3/functional/es3fNegativeBufferApiTests.cpp

index a2613be..734857f 100644 (file)
@@ -356,8 +356,12 @@ void NegativeBufferApiTests::init (void)
                        m_log << TestLog::Section("", "GL_INVALID_VALUE is generated if target is GL_UNIFORM_BUFFER and offset is not a multiple of GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT.");
                        int alignment;
                        glGetIntegerv(GL_UNIFORM_BUFFER_OFFSET_ALIGNMENT, &alignment);
-                       glBindBufferRange(GL_UNIFORM_BUFFER, 0, bufU, alignment+1, 4);
-                       expectError(GL_INVALID_VALUE);
+
+                       if (alignment > 1)
+                       {
+                               glBindBufferRange(GL_UNIFORM_BUFFER, 0, bufU, alignment+1, 4);
+                               expectError(GL_INVALID_VALUE);
+                       }
                        m_log << TestLog::EndSection;
 
                        glDeleteBuffers(1, &bufU);