cpuidle/poll: Ensure IRQs stay disabled after cpuidle_state::enter() calls
authorPeter Zijlstra <peterz@infradead.org>
Thu, 12 Jan 2023 19:43:17 +0000 (20:43 +0100)
committerIngo Molnar <mingo@kernel.org>
Fri, 13 Jan 2023 10:03:21 +0000 (11:03 +0100)
Make cpuidle_state::enter() methods IRQ state invariant on exit.

Additionally make sure to use raw_local_irq_*() methods since this
cpuidle callback will be called with RCU already disabled.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Tony Lindgren <tony@atomide.com>
Tested-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20230112195539.515253662@infradead.org
drivers/cpuidle/poll_state.c

index f7e8361..1f578ed 100644 (file)
@@ -17,7 +17,7 @@ static int __cpuidle poll_idle(struct cpuidle_device *dev,
 
        dev->poll_time_limit = false;
 
-       local_irq_enable();
+       raw_local_irq_enable();
        if (!current_set_polling_and_test()) {
                unsigned int loop_count = 0;
                u64 limit;
@@ -36,6 +36,8 @@ static int __cpuidle poll_idle(struct cpuidle_device *dev,
                        }
                }
        }
+       raw_local_irq_disable();
+
        current_clr_polling();
 
        return index;