Improve error details on DNS Telemetry test failure (#40665)
authorMiha Zupan <mihazupan.zupan1@gmail.com>
Tue, 11 Aug 2020 16:47:36 +0000 (18:47 +0200)
committerGitHub <noreply@github.com>
Tue, 11 Aug 2020 16:47:36 +0000 (18:47 +0200)
src/libraries/System.Net.NameResolution/tests/FunctionalTests/TelemetryTest.cs

index 739ae3c..e0516f6 100644 (file)
@@ -49,8 +49,6 @@ namespace System.Net.NameResolution.Tests
 
                 Assert.DoesNotContain(events, e => e.EventId == 0); // errors from the EventSource itself
 
-                Assert.True(events.Count >= 2 * 6);
-
                 EventWrittenEventArgs[] starts = events.Where(e => e.EventName == "ResolutionStart").ToArray();
                 Assert.Equal(6, starts.Length);
                 Assert.All(starts, s => Assert.Equal(ValidHostName, Assert.Single(s.Payload).ToString()));
@@ -87,8 +85,6 @@ namespace System.Net.NameResolution.Tests
 
                 Assert.DoesNotContain(events, e => e.EventId == 0); // errors from the EventSource itself
 
-                Assert.True(events.Count >= 3 * 6);
-
                 EventWrittenEventArgs[] starts = events.Where(e => e.EventName == "ResolutionStart").ToArray();
                 Assert.Equal(6, starts.Length);
                 Assert.All(starts, s => Assert.Equal(InvalidHostName, Assert.Single(s.Payload).ToString()));
@@ -129,8 +125,6 @@ namespace System.Net.NameResolution.Tests
                 Assert.DoesNotContain(events, e => e.EventId == 0); // errors from the EventSource itself
 
                 // Each GetHostEntry over an IP will yield 2 resolutions
-                Assert.True(events.Count >= 2 * 2 * 6);
-
                 EventWrittenEventArgs[] starts = events.Where(e => e.EventName == "ResolutionStart").ToArray();
                 Assert.Equal(12, starts.Length);
                 Assert.Equal(6, starts.Count(s => Assert.Single(s.Payload).ToString() == ValidIPAddress));