media: meson/vdec: always init coef_node_start

It's hard for code analyzers to see that coef_node_start is
always initialized (and actually hard for humans as well!).

So change the last 'else if' to an 'else' so it is clear that
coef_node_startis always set.

This fixes a compile warning:

drivers/staging/media/meson/vdec/codec_vp9.c:1689:41: warning: 'coef_node_start' may be used uninitialized [-Wmaybe-uninitialized]
 1689 |                         coef_node_start = coef_node_start + 1;
      |                         ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
drivers/staging/media/meson/vdec/codec_vp9.c:1551:19: note: 'coef_node_start' was declared here
 1551 |         int node, coef_node_start, coef_count_node_start;
      |                   ^~~~~~~~~~~~~~~

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/staging/media/meson/vdec/codec_vp9.c b/drivers/staging/media/meson/vdec/codec_vp9.c
index 897f5d7..cf0f58d 100644 (file)
--- a/drivers/staging/media/meson/vdec/codec_vp9.c
+++ b/drivers/staging/media/meson/vdec/codec_vp9.c
@@ -1649,8 +1649,7 @@ static void adapt_coef_probs(int prev_kf, int cur_kf, int pre_fc,
                        else if (coef_count_node_start ==
                                        VP9_MV_BITS_1_COUNT_START)
                                coef_node_start = VP9_MV_BITS_1_START;
-                       else if (coef_count_node_start ==
-                                       VP9_MV_CLASS0_HP_0_COUNT_START)
+                       else /* node_start == VP9_MV_CLASS0_HP_0_COUNT_START */
                                coef_node_start = VP9_MV_CLASS0_HP_0_START;
 
                        den = count[coef_count_node_start] +