Fix defects detected by static analysis tool 53/318553/1
authorMd. Farhan Mahtab/NC eXperience Group /SRBD/Engineer/Samsung Electronics <farhan.m1@samsung.com>
Wed, 2 Oct 2024 06:58:33 +0000 (12:58 +0600)
committerMd. Farhan Mahtab/NC eXperience Group /SRBD/Engineer/Samsung Electronics <farhan.m1@samsung.com>
Wed, 2 Oct 2024 06:58:33 +0000 (12:58 +0600)
[Problem] Issues detected by Static Analysis Tool
[Cause & Measure]
 Cause   : scrollbarStyle is not properly disposed
 Measure : scrollbarStyle is properly disposed

Change-Id: I3e362559f147fb4d26dc60dd22f4e7d9872d9a82
Signed-off-by: Md. Farhan Mahtab/NC eXperience Group /SRBD/Engineer/Samsung Electronics <farhan.m1@samsung.com>
TaskBar/Views/MainView.cs

index 17a46ee79b1c832ae4f52397825addd60e9466ac..ccc6a5c37db61b7a19bd07c5af2c223c19459787 100644 (file)
@@ -106,7 +106,7 @@ namespace TaskBar.Views
 
         private void setScrollBar()
         {
-            var scrollbarStyle = ThemeManager.GetStyle("Tizen.NUI.Components.Scrollbar") as ScrollbarStyle;
+            ScrollbarStyle scrollbarStyle = ThemeManager.GetStyle("Tizen.NUI.Components.Scrollbar") as ScrollbarStyle;
             scrollbarStyle.ThumbColor = new Color("#FFFEFE");
             scrollbarStyle.TrackPadding = new Extents(0, 0, 0, 3).SpToPx();
             scrollbarStyle.Opacity = 0.35f;
@@ -114,7 +114,7 @@ namespace TaskBar.Views
             scrollbarStyle.ThumbColor = new Color("#FFFEFE");
             scrollbarStyle.CornerRadius = new Vector4(4, 4, 4, 4);
             Scrollbar = new Scrollbar(scrollbarStyle);
-
+            scrollbarStyle.Dispose();
             var thumb = Scrollbar.Children.Skip(1).FirstOrDefault() as ImageView;
 
             if (thumb != null)
@@ -126,7 +126,7 @@ namespace TaskBar.Views
                 thumb.BoxShadow = new Shadow(8.0f, new Color(0.0f, 0.0f, 0.0f, 0.16f), new Vector2(0.0f, 2.0f));
             }
 
-            scrollbarStyle.Dispose();
+
         }
 
         private void OnAppListUpdate(View view, int diff)