sx8: fix an error code in carm_init_one()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 1 Oct 2021 12:27:22 +0000 (15:27 +0300)
committerJens Axboe <axboe@kernel.dk>
Mon, 18 Oct 2021 20:42:30 +0000 (14:42 -0600)
Return a negative error code here on this error path instead of
returning success.

Fixes: 637208e74a86 ("block/sx8: add error handling support for add_disk()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211001122722.GC2283@kili
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/sx8.c

index 1c79248..d1676fe 100644 (file)
@@ -1511,8 +1511,10 @@ static int carm_init_one (struct pci_dev *pdev, const struct pci_device_id *ent)
        DPRINTK("waiting for probe_comp\n");
        host->probe_err = -ENODEV;
        wait_for_completion(&host->probe_comp);
-       if (host->probe_err)
+       if (host->probe_err) {
+               rc = host->probe_err;
                goto err_out_free_irq;
+       }
 
        printk(KERN_INFO "%s: pci %s, ports %d, io %llx, irq %u, major %d\n",
               host->name, pci_name(pdev), (int) CARM_MAX_PORTS,