Refactoring and increasing negative test cases for __test_dpm_black_list_verify_privi...

Change-Id: Ia20b9191bb71482464ea9ce517dddcc6db4a9f35
Signed-off-by: tranthanhtung2001 <tran.tung@samsung.com>

diff --git a/test/tc-privilege-black-list.c b/test/tc-privilege-black-list.c
index c1e8841c0bea8226e12ba95f3b09a2f725f14622..4b247f4ce3bbe640a533961576c41385988e6ba4 100644 (file)
--- a/test/tc-privilege-black-list.c
+++ b/test/tc-privilege-black-list.c
@@ -268,12 +268,7 @@ void __test_dpm_black_list_verify_privilege()
        printf("\nTest privilege_manager_verify_privilege with banned privilege\n\n");
        __color_to_origin();
 
-       __tcinfo(goal, POS_TC_PREFIX "uid = 0, Get wrt black list");
-       __tcinfo(expect, PRVMGR_ERR_NONE);
-       ret = privilege_info_get_black_list(0, PRVMGR_PACKAGE_TYPE_WRT, &black_list);
-       __print_result('m', ret);
-       __print_privilege_list(black_list);
-       __print_line();
+       black_list = __privilege_info_get_black_list_and_check_return_code(0, PRVMGR_PACKAGE_TYPE_WRT, PRVMGR_ERR_NONE);
 
        __tcinfo(goal, NEG_TC_PREFIX "2.4, wrt, Name=OK, Version=OK, Level=OK -- Public => Using Banned Privilege");
        __privinfo("http://tizen.org/privilege/alarm", NULL, NULL);
@@ -287,25 +282,18 @@ void __test_dpm_black_list_verify_privilege()
        __privinfo("http://tizen.org/privilege/telephony", NULL, NULL);
        __tcinfo(expect, PRVMGR_ERR_USING_BANNED_PRIVILEGE);
        ret = privilege_manager_verify_privilege(0, "2.4", PRVMGR_PACKAGE_TYPE_WRT, privilege_list, PRVMGR_PACKAGE_VISIBILITY_PUBLIC, &error_message);
+
+       __check_the_return_code('m', PRVMGR_ERR_USING_BANNED_PRIVILEGE, ret);
        ShowErrorMsg(error_message != NULL, error_message, ret);
-       __print_result('m', ret);
-       __print_line();
 
        gfree(privilege_list);
 
-       __tcinfo(goal, POS_TC_PREFIX "uid = 0, Remove all banned wrt privileges");
-       __tcinfo(expect, PRVMGR_ERR_NONE);
        ret = privilege_manager_unset_black_list(0, PRVMGR_PACKAGE_TYPE_WRT, black_list);
-       __print_result('m', ret);
-       __print_line();
+       __check_the_return_code('m', PRVMGR_ERR_NONE, ret);
        gfree(black_list);
 
-       __tcinfo(goal, POS_TC_PREFIX "uid = 0, Get wrt black list");
-       __tcinfo(expect, PRVMGR_ERR_NONE);
-       ret = privilege_info_get_black_list(0, PRVMGR_PACKAGE_TYPE_WRT, &black_list);
-       __print_result('m', ret);
-       __print_privilege_list(black_list);
-       __print_line();
+       black_list = __privilege_info_get_black_list_and_check_return_code(0, PRVMGR_PACKAGE_TYPE_WRT, PRVMGR_ERR_NONE);
+       gfree(black_list);
 
        __tcinfo(goal, POS_TC_PREFIX "2.4, wrt, Name=OK, Version=OK, Level=OK -- Public ");
        __privinfo("http://tizen.org/privilege/alarm", NULL, NULL);
@@ -317,11 +305,38 @@ void __test_dpm_black_list_verify_privilege()
        __privinfo("http://tizen.org/privilege/mediacapture", NULL, NULL);
        __privinfo("http://tizen.org/privilege/package.info", NULL, NULL);
        __privinfo("http://tizen.org/privilege/telephony", NULL, NULL);
-       __tcinfo(expect, PRVMGR_ERR_NONE);
        ret = privilege_manager_verify_privilege(0, "2.4", PRVMGR_PACKAGE_TYPE_WRT, privilege_list, PRVMGR_PACKAGE_VISIBILITY_PUBLIC, &error_message);
+
+       __check_the_return_code('m', PRVMGR_ERR_NONE, ret);
        ShowErrorMsg(error_message != NULL, error_message, ret);
-       __print_result('m', ret);
-       __print_line();
+
+       gfree(privilege_list);
+
+       __privinfo("http://tizen.org/privilege/telephony", NULL, NULL);
+       /* Verify privilege when package_type is wrong */
+       __tcinfo(goal, NEG_TC_PREFIX "Verify privilege when package_type is PRVMGR_PACKAGE_TYPE_MAX");
+
+       ret = privilege_manager_verify_privilege(
+               0,
+               "2.4",
+               PRVMGR_PACKAGE_TYPE_MAX,
+               privilege_list,
+               PRVMGR_PACKAGE_VISIBILITY_PUBLIC,
+               &error_message);
+
+       __check_the_return_code('m', PRVMGR_ERR_INVALID_PARAMETER, ret);
+
+       __tcinfo(goal, NEG_TC_PREFIX "Verify privilege when package_type is PRVMGR_PACKAGE_TYPE_NONE");
+
+       ret = privilege_manager_verify_privilege(
+               0,
+               "2.4",
+               PRVMGR_PACKAGE_TYPE_NONE,
+               privilege_list,
+               PRVMGR_PACKAGE_VISIBILITY_PUBLIC,
+               &error_message);
+
+       __check_the_return_code('m', PRVMGR_ERR_INVALID_PARAMETER, ret);
 
        gfree(privilege_list);