serial: liteuart: separate rx loop from poll timer
authorGabriel Somlo <gsomlo@gmail.com>
Wed, 23 Nov 2022 13:04:56 +0000 (08:04 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jan 2023 13:59:40 +0000 (14:59 +0100)
Convert the rx loop into its own dedicated function, and (for now)
call it from the poll timer. This is in preparation for adding irq
support to the receive path.

Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20221123130500.1030189-11-gsomlo@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/liteuart.c

index 62bfd2e..ab6837f 100644 (file)
@@ -68,10 +68,8 @@ static struct uart_driver liteuart_driver = {
 #endif
 };
 
-static void liteuart_timer(struct timer_list *t)
+static void liteuart_rx_chars(struct uart_port *port)
 {
-       struct liteuart_port *uart = from_timer(uart, t, timer);
-       struct uart_port *port = &uart->port;
        unsigned char __iomem *membase = port->membase;
        u8 ch;
 
@@ -88,6 +86,14 @@ static void liteuart_timer(struct timer_list *t)
        }
 
        tty_flip_buffer_push(&port->state->port);
+}
+
+static void liteuart_timer(struct timer_list *t)
+{
+       struct liteuart_port *uart = from_timer(uart, t, timer);
+       struct uart_port *port = &uart->port;
+
+       liteuart_rx_chars(port);
 
        mod_timer(&uart->timer, jiffies + uart_poll_timeout(port));
 }