Fix stringop-truncation warning
authorSangwan Kwon <sangwan.kwon@samsung.com>
Fri, 10 Jan 2020 06:58:37 +0000 (15:58 +0900)
committer권상완/Security 2Lab(SR)/Engineer/삼성전자 <sangwan.kwon@samsung.com>
Tue, 14 Jan 2020 01:57:30 +0000 (10:57 +0900)
Pathname sockets: The pathname in sun_path should be null-terminated.
ref: http://man7.org/linux/man-pages/man7/unix.7.html

Signed-off-by: Sangwan Kwon <sangwan.kwon@samsung.com>
src/vist/rmi/impl/ondemand/socket.cpp

index b995b18..110e3fc 100644 (file)
@@ -58,7 +58,8 @@ Socket::Socket(const std::string& path)
 
        ::sockaddr_un addr;
        addr.sun_family = AF_UNIX;
-       ::strncpy(addr.sun_path, path.c_str(), sizeof(sockaddr_un::sun_path));
+       ::strncpy(addr.sun_path, path.c_str(), sizeof(sockaddr_un::sun_path) - 1);
+       addr.sun_path[sizeof(sockaddr_un::sun_path) - 1] = '\0';
 
        if (addr.sun_path[0] == '@')
                addr.sun_path[0] = '\0';