Revert "[lldb] Explicitly use the configuration architecture when building test execu...
authorRaphael Isemann <teemperor@gmail.com>
Thu, 22 Oct 2020 16:42:19 +0000 (18:42 +0200)
committerRaphael Isemann <teemperor@gmail.com>
Thu, 22 Oct 2020 16:42:19 +0000 (18:42 +0200)
This reverts commit 41185226f6d80663b4a1064c6f47581ee567d78d.

Causes TestQuoting to fail on Windows.

lldb/packages/Python/lldbsuite/test/builders/builder.py
lldb/packages/Python/lldbsuite/test/lldbtest.py

index 6c95842..fbfa867 100644 (file)
@@ -93,7 +93,11 @@ class Builder:
         Helper function to return the key-value string to specify the architecture
         used for the make system.
         """
-        return ("ARCH=" + architecture) if architecture else ""
+        arch = architecture if architecture else None
+        if not arch and configuration.arch:
+            arch = configuration.arch
+
+        return ("ARCH=" + arch) if arch else ""
 
     def getCCSpec(self, compiler):
         """
index f469ce8..69da391 100644 (file)
@@ -2606,9 +2606,6 @@ FileCheck output:
         """Platform specific way to build the default binaries."""
         module = builder_module()
 
-        if not architecture and configuration.arch:
-            architecture = configuration.arch
-
         dictionary = lldbplatformutil.finalize_build_dictionary(dictionary)
         if self.getDebugInfo() is None:
             return self.buildDefault(architecture, compiler, dictionary)