validate-report: Add new check for top-level seek
authorEdward Hervey <edward@centricular.com>
Fri, 15 Jun 2018 08:52:46 +0000 (10:52 +0200)
committerThibault Saunier <tsaunier@igalia.com>
Thu, 30 Apr 2020 16:40:12 +0000 (12:40 -0400)
This issue is to detect seeks that don't result in segments
with identical seqnums. This check can be done at the top-level
scenario

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-devtools/-/merge_requests/174>

validate/gst/validate/gst-validate-report.c
validate/gst/validate/gst-validate-report.h

index ea64dbc..7b1224e 100644 (file)
@@ -383,6 +383,8 @@ gst_validate_report_load_issues (void)
       "seek event wasn't handled", NULL);
   REGISTER_VALIDATE_ISSUE (CRITICAL, EVENT_SEEK_RESULT_POSITION_WRONG,
       "position after a seek is wrong", NULL);
+  REGISTER_VALIDATE_ISSUE (CRITICAL, EVENT_SEEK_INVALID_SEQNUM,
+      "segments after a seek don't have the same seqnum", NULL);
 
   REGISTER_VALIDATE_ISSUE (WARNING, EVENT_EOS_WITHOUT_SEGMENT,
       "EOS received without segment event before",
index c211e25..bc47ffd 100644 (file)
@@ -106,6 +106,7 @@ typedef enum {
 #define EVENT_CAPS_DUPLICATE                     _QUARK("event::caps-duplicate")
 #define EVENT_SEEK_NOT_HANDLED                   _QUARK("event::seek-not-handled")
 #define EVENT_SEEK_RESULT_POSITION_WRONG         _QUARK("event::seek-result-position-wrong")
+#define EVENT_SEEK_INVALID_SEQNUM                _QUARK("event::seek-invalid_seqnum")
 #define EVENT_EOS_WITHOUT_SEGMENT                _QUARK("event::eos-without-segment")
 #define EVENT_INVALID_SEQNUM                     _QUARK("event::invalid-seqnum")