projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
3b32c99
)
net: ksz884x: fix missing pci_disable_device() on error in pcidev_init()
author
Yang Yingliang
<yangyingliang@huawei.com>
Mon, 24 Oct 2022 13:13:38 +0000
(21:13 +0800)
committer
Jakub Kicinski
<kuba@kernel.org>
Wed, 26 Oct 2022 02:46:35 +0000
(19:46 -0700)
pci_disable_device() need be called while module exiting, switch to use
pcim_enable(), pci_disable_device() will be called in pcim_release()
while unbinding device.
Fixes:
8ca86fd83eae
("net: Micrel KSZ8841/2 PCI Ethernet driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link:
https://lore.kernel.org/r/20221024131338.2848959-1-yangyingliang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/micrel/ksz884x.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/micrel/ksz884x.c
b/drivers/net/ethernet/micrel/ksz884x.c
index
4685200
..
e6acd1e
100644
(file)
--- a/
drivers/net/ethernet/micrel/ksz884x.c
+++ b/
drivers/net/ethernet/micrel/ksz884x.c
@@
-6851,7
+6851,7
@@
static int pcidev_init(struct pci_dev *pdev, const struct pci_device_id *id)
char banner[sizeof(version)];
struct ksz_switch *sw = NULL;
- result = pci_enable_device(pdev);
+ result = pci
m
_enable_device(pdev);
if (result)
return result;