re PR middle-end/35818 (ICE on incomplete array in shared clause)

	PR middle-end/35818
	* omp-low.c (scan_sharing_clauses) <case OMP_CLAUSE_SHARED>: Don't
	call is_variable_sized if decl has incomplete type.

	* gcc.dg/gomp/pr35818.c: New test.

From-SVN: r133875

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index aec6128..29a3cce 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2008-04-03  Jakub Jelinek  <jakub@redhat.com>
+
+       PR middle-end/35818
+       * omp-low.c (scan_sharing_clauses) <case OMP_CLAUSE_SHARED>: Don't
+       call is_variable_sized if decl has incomplete type.
+
 2008-04-03  H.J. Lu  <hongjiu.lu@intel.com>
 
        * config/i386/i386-protos.h (ix86_aligned_p): Removed.

diff --git a/gcc/omp-low.c b/gcc/omp-low.c
index 45602c2..ffdf447 100644 (file)
--- a/gcc/omp-low.c
+++ b/gcc/omp-low.c
@@ -993,7 +993,8 @@ scan_sharing_clauses (tree clauses, omp_context *ctx)
        case OMP_CLAUSE_SHARED:
          gcc_assert (is_parallel_ctx (ctx));
          decl = OMP_CLAUSE_DECL (c);
-         gcc_assert (!is_variable_sized (decl));
+         gcc_assert (!COMPLETE_TYPE_P (TREE_TYPE (decl))
+                     || !is_variable_sized (decl));
          by_ref = use_pointer_for_field (decl, ctx);
          /* Global variables don't need to be copied,
             the receiver side will use them directly.  */

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index bd7e6e5..1bad997 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,8 @@
 2008-04-03  Jakub Jelinek  <jakub@redhat.com>
 
+       PR middle-end/35818
+       * gcc.dg/gomp/pr35818.c: New test.
+
        PR fortran/35786
        * gfortran.dg/gomp/pr35786-1.f90: New test.
        * gfortran.dg/gomp/pr35786-2.f90: New test.

diff --git a/gcc/testsuite/gcc.dg/gomp/pr35818.c b/gcc/testsuite/gcc.dg/gomp/pr35818.c
new file mode 100644 (file)
index 0000000..b2165eb
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/gomp/pr35818.c
@@ -0,0 +1,16 @@
+/* PR middle-end/35818 */
+/* { dg-do compile } */
+/* { dg-options "-fopenmp" } */
+
+extern int a[];
+
+void
+foo (void)
+{
+#pragma omp parallel
+#pragma omp master
+  a[3] = 1;
+#pragma omp parallel shared(a)
+#pragma omp master
+  a[3] = 1;
+}