tracing: Do not show filter file for ftrace internal events
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 9 May 2018 13:48:41 +0000 (09:48 -0400)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Tue, 29 May 2018 12:28:46 +0000 (08:28 -0400)
The filter file in the ftrace internal events, like in
/sys/kernel/tracing/events/ftrace/function/filter is not attached to any
functionality. Do not create them as they are meaningless.

In the future, if an ftrace internal event gets filter functionality, then
it will need to create it directly.

Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
kernel/trace/trace_events.c

index 5b64790..14ff4ff 100644 (file)
@@ -2007,16 +2007,18 @@ event_create_dir(struct dentry *parent, struct trace_event_file *file)
                        return -1;
                }
        }
-       trace_create_file("filter", 0644, file->dir, file,
-                         &ftrace_event_filter_fops);
 
        /*
         * Only event directories that can be enabled should have
-        * triggers.
+        * triggers or filters.
         */
-       if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE))
+       if (!(call->flags & TRACE_EVENT_FL_IGNORE_ENABLE)) {
+               trace_create_file("filter", 0644, file->dir, file,
+                                 &ftrace_event_filter_fops);
+
                trace_create_file("trigger", 0644, file->dir, file,
                                  &event_trigger_fops);
+       }
 
 #ifdef CONFIG_HIST_TRIGGERS
        trace_create_file("hist", 0444, file->dir, file,