Check after getting return 98/244498/1
authorYunjin Lee <yunjin-.lee@samsung.com>
Mon, 21 Sep 2020 02:36:04 +0000 (11:36 +0900)
committerYunjin Lee <yunjin-.lee@samsung.com>
Mon, 21 Sep 2020 02:36:09 +0000 (11:36 +0900)
- When calling __convert_return_value(), pass return value and
derived out value after getting return cleary. On some target, in
this case emulator image, it fails to reference passed out param
pointer, hence separate them to be safe.

Change-Id: I7ffb4f9dd06be466485952800a280c5fd6973254
Signed-off-by: Yunjin Lee <yunjin-.lee@samsung.com>
src/privilege_information.c

index 6de2c21..6d7e2e7 100755 (executable)
@@ -108,7 +108,9 @@ int privilege_info_get_display_name(const char *api_version, const char *privile
        TryReturn(api_version != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] api_version is NULL");
        TryReturn(privilege != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] privilege is NULL");
 
-       return __convert_return_value(privilege_info_get_privilege_display_name(privilege, display_name), *display_name);
+       int ret = privilege_info_get_privilege_display_name(privilege, display_name);
+
+       return __convert_return_value(ret, *display_name);
 }
 
 PI_API
@@ -117,7 +119,9 @@ int privilege_info_get_description(const char *api_version, const char *privileg
        TryReturn(api_version != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] api_version is NULL");
        TryReturn(privilege != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] privilege is NULL");
 
-       return __convert_return_value(privilege_info_get_privilege_description(privilege, description), *description);
+       int ret = privilege_info_get_privilege_description(privilege, description);
+
+       return __convert_return_value(ret, *description);
 }
 
 PI_API
@@ -127,7 +131,9 @@ int privilege_info_get_display_name_by_pkgtype(const char *package_type, const c
        TryReturn(api_version != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] api_version is NULL");
        TryReturn(privilege != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] privilege is NULL");
 
-       return __convert_return_value(privilege_info_get_privilege_display_name_by_package_type(privilege, api_version, __convert_package_type(package_type), display_name), *display_name);
+       int ret = privilege_info_get_privilege_display_name_by_package_type(privilege, api_version, __convert_package_type(package_type), display_name);
+
+       return __convert_return_value(ret, *display_name);
 }
 
 PI_API
@@ -137,7 +143,9 @@ int privilege_info_get_description_by_pkgtype(const char *package_type, const ch
        TryReturn(api_version != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] api_version is NULL");
        TryReturn(privilege != NULL, , PRVINFO_ERROR_INVALID_PARAMETER, "[PRVINFO_ERROR_INVALID_PARAMETER] privilege is NULL");
 
-       return __convert_return_value(privilege_info_get_privilege_description_by_package_type(privilege, api_version, __convert_package_type(package_type), description), *description);
+       int ret = privilege_info_get_privilege_description_by_package_type(privilege, api_version, __convert_package_type(package_type), description);
+
+       return __convert_return_value(ret, *description);
 }
 
 PI_API