* sol-thread.c (_initialize_sol_thread): Add FIXME regarding

	order of _initialize_* fns.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index d92a706..86ba16e 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,8 @@
 2008-09-12  Doug Evans  <dje@google.com>
 
+       * sol-thread.c (_initialize_sol_thread): Add FIXME regarding
+       order of _initialize_* fns.
+
        * dwarf2read.c (comp_unit_head): Rename first_die_ptr to
        first_die_offset.  All uses updated.
        Delete unused members cu_head_ptr, next.

diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c
index f36e4ea..8f99ac1 100644 (file)
--- a/gdb/sol-thread.c
+++ b/gdb/sol-thread.c
@@ -1663,6 +1663,10 @@ _initialize_sol_thread (void)
   add_cmd ("sol-threads", class_maintenance, info_solthreads,
           _("Show info on Solaris user threads."), &maintenanceinfolist);
 
+  /* FIXME: This code takes errant advantage of the order in which
+     initialization routines are run.  _initialize_corelow must run before
+     this one otherwise orig_core_ops will still contain zeros and the work
+     of init_sol_core_ops will be undone.  */
   memcpy (&orig_core_ops, &core_ops, sizeof (struct target_ops));
   memcpy (&core_ops, &sol_core_ops, sizeof (struct target_ops));
   add_target (&core_ops);