net: use DMA_x_DEVICE and dma_mapping_error with skb_frag_dma_map
authorIan Campbell <ian.campbell@citrix.com>
Thu, 6 Oct 2011 10:10:48 +0000 (11:10 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Oct 2011 20:17:20 +0000 (16:17 -0400)
When I converted some drivers from pci_map_page to skb_frag_dma_map I
neglected to convert PCI_DMA_xDEVICE into DMA_x_DEVICE and
pci_dma_mapping_error into dma_mapping_error.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
29 files changed:
drivers/infiniband/hw/amso1100/c2.c
drivers/infiniband/hw/nes/nes_nic.c
drivers/net/ethernet/alteon/acenic.c
drivers/net/ethernet/atheros/atl1c/atl1c_main.c
drivers/net/ethernet/atheros/atl1e/atl1e_main.c
drivers/net/ethernet/atheros/atlx/atl1.c
drivers/net/ethernet/broadcom/bnx2.c
drivers/net/ethernet/broadcom/tg3.c
drivers/net/ethernet/chelsio/cxgb/sge.c
drivers/net/ethernet/chelsio/cxgb3/sge.c
drivers/net/ethernet/cisco/enic/enic_main.c
drivers/net/ethernet/marvell/skge.c
drivers/net/ethernet/marvell/sky2.c
drivers/net/ethernet/myricom/myri10ge/myri10ge.c
drivers/net/ethernet/natsemi/ns83820.c
drivers/net/ethernet/neterion/s2io.c
drivers/net/ethernet/nvidia/forcedeth.c
drivers/net/ethernet/pasemi/pasemi_mac.c
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c
drivers/net/ethernet/qlogic/qla3xxx.c
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
drivers/net/ethernet/qlogic/qlge/qlge_main.c
drivers/net/ethernet/sfc/tx.c
drivers/net/ethernet/sun/cassini.c
drivers/net/ethernet/sun/sungem.c
drivers/net/ethernet/tehuti/tehuti.c
drivers/net/ethernet/via/via-velocity.c
drivers/net/vmxnet3/vmxnet3_drv.c
drivers/staging/et131x/et1310_tx.c

index 6a8f36e..6e85a75 100644 (file)
@@ -803,8 +803,7 @@ static int c2_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
                        skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
                        maplen = frag->size;
                        mapaddr = skb_frag_dma_map(&c2dev->pcidev->dev, frag,
-                                                  0, maplen,
-                                                  PCI_DMA_TODEVICE);
+                                                  0, maplen, DMA_TO_DEVICE);
                        elem = elem->next;
                        elem->skb = NULL;
                        elem->mapaddr = mapaddr;
index 96cb35a..7cb7f29 100644 (file)
@@ -445,7 +445,7 @@ static int nes_nic_send(struct sk_buff *skb, struct net_device *netdev)
                                &skb_shinfo(skb)->frags[skb_fragment_index];
                        bus_address = skb_frag_dma_map(&nesdev->pcidev->dev,
                                                       frag, 0, frag->size,
-                                                      PCI_DMA_TODEVICE);
+                                                      DMA_TO_DEVICE);
                        wqe_fragment_length[wqe_fragment_index] =
                                        cpu_to_le16(skb_shinfo(skb)->frags[skb_fragment_index].size);
                        set_wqe_64bit_value(nic_sqe->wqe_words, NES_NIC_SQ_WQE_FRAG0_LOW_IDX+(2*wqe_fragment_index),
@@ -566,7 +566,7 @@ tso_sq_no_longer_full:
                                tso_bus_address[tso_frag_count] =
                                        skb_frag_dma_map(&nesdev->pcidev->dev,
                                                         frag, 0, frag->size,
-                                                        PCI_DMA_TODEVICE);
+                                                        DMA_TO_DEVICE);
                        }
 
                        tso_frag_index = 0;
index 8794cf8..b1a4e82 100644 (file)
@@ -2487,7 +2487,7 @@ restart:
 
                        mapping = skb_frag_dma_map(&ap->pdev->dev, frag, 0,
                                                   frag->size,
-                                                  PCI_DMA_TODEVICE);
+                                                  DMA_TO_DEVICE);
 
                        flagsize = (frag->size << 16);
                        if (skb->ip_summed == CHECKSUM_PARTIAL)
index 2b9f925..12a0b30 100644 (file)
@@ -2183,7 +2183,7 @@ static void atl1c_tx_map(struct atl1c_adapter *adapter,
                buffer_info->dma = skb_frag_dma_map(&adapter->pdev->dev,
                                                    frag, 0,
                                                    buffer_info->length,
-                                                   PCI_DMA_TODEVICE);
+                                                   DMA_TO_DEVICE);
                ATL1C_SET_BUFFER_STATE(buffer_info, ATL1C_BUFFER_BUSY);
                ATL1C_SET_PCIMAP_TYPE(buffer_info, ATL1C_PCIMAP_PAGE,
                        ATL1C_PCIMAP_TODEVICE);
index 7e27eb3..97c45a4 100644 (file)
@@ -1769,7 +1769,7 @@ static void atl1e_tx_map(struct atl1e_adapter *adapter,
                                                          frag,
                                                          (i * MAX_TX_BUF_LEN),
                                                          tx_buffer->length,
-                                                         PCI_DMA_TODEVICE);
+                                                         DMA_TO_DEVICE);
                        ATL1E_SET_PCIMAP_TYPE(tx_buffer, ATL1E_TX_PCIMAP_PAGE);
                        use_tpd->buffer_addr = cpu_to_le64(tx_buffer->dma);
                        use_tpd->word2 = (use_tpd->word2 & (~TPD_BUFLEN_MASK)) |
index edf826a..43511ab 100644 (file)
@@ -2285,7 +2285,7 @@ static void atl1_tx_map(struct atl1_adapter *adapter, struct sk_buff *skb,
                        buf_len -= buffer_info->length;
                        buffer_info->dma = skb_frag_dma_map(&adapter->pdev->dev,
                                frag, i * ATL1_MAX_TX_BUF_LEN,
-                               buffer_info->length, PCI_DMA_TODEVICE);
+                               buffer_info->length, DMA_TO_DEVICE);
 
                        if (++next_to_use == tpd_ring->count)
                                next_to_use = 0;
index 21bdda3..ad24d8c 100644 (file)
@@ -6539,7 +6539,7 @@ bnx2_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
                len = frag->size;
                mapping = skb_frag_dma_map(&bp->pdev->dev, frag, 0, len,
-                                          PCI_DMA_TODEVICE);
+                                          DMA_TO_DEVICE);
                if (dma_mapping_error(&bp->pdev->dev, mapping))
                        goto dma_error;
                dma_unmap_addr_set(&txr->tx_buf_ring[ring_prod], mapping,
index 26c6bd4..9dbd1af 100644 (file)
@@ -6779,12 +6779,12 @@ static netdev_tx_t tg3_start_xmit(struct sk_buff *skb, struct net_device *dev)
 
                        len = frag->size;
                        mapping = skb_frag_dma_map(&tp->pdev->dev, frag, 0,
-                                                  len, PCI_DMA_TODEVICE);
+                                                  len, DMA_TO_DEVICE);
 
                        tnapi->tx_buffers[entry].skb = NULL;
                        dma_unmap_addr_set(&tnapi->tx_buffers[entry], mapping,
                                           mapping);
-                       if (pci_dma_mapping_error(tp->pdev, mapping))
+                       if (dma_mapping_error(&tp->pdev->dev, mapping))
                                goto dma_error;
 
                        if (tg3_tx_frag_set(tnapi, &entry, &budget, mapping,
index 7cde425..0a511c4 100644 (file)
@@ -1278,7 +1278,7 @@ static inline void write_tx_descs(struct adapter *adapter, struct sk_buff *skb,
                }
 
                mapping = skb_frag_dma_map(&adapter->pdev->dev, frag, 0,
-                                          frag->size, PCI_DMA_TODEVICE);
+                                          frag->size, DMA_TO_DEVICE);
                desc_mapping = mapping;
                desc_len = frag->size;
 
index a0baaa0..2f46b37 100644 (file)
@@ -980,7 +980,7 @@ static inline unsigned int make_sgl(const struct sk_buff *skb,
                skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 
                mapping = skb_frag_dma_map(&pdev->dev, frag, 0, frag->size,
-                                          PCI_DMA_TODEVICE);
+                                          DMA_TO_DEVICE);
                sgp->len[j] = cpu_to_be32(frag->size);
                sgp->addr[j] = cpu_to_be64(mapping);
                j ^= 1;
index aeab6cd..1bc908f 100644 (file)
@@ -607,7 +607,7 @@ static inline void enic_queue_wq_skb_cont(struct enic *enic,
                enic_queue_wq_desc_cont(wq, skb,
                        skb_frag_dma_map(&enic->pdev->dev,
                                         frag, 0, frag->size,
-                                        PCI_DMA_TODEVICE),
+                                        DMA_TO_DEVICE),
                        frag->size,
                        (len_left == 0),        /* EOP? */
                        loopback);
@@ -726,7 +726,7 @@ static inline void enic_queue_wq_skb_tso(struct enic *enic,
                                (unsigned int)WQ_ENET_MAX_DESC_LEN);
                        dma_addr = skb_frag_dma_map(&enic->pdev->dev, frag,
                                                    offset, len,
-                                                   PCI_DMA_TODEVICE);
+                                                   DMA_TO_DEVICE);
                        enic_queue_wq_desc_cont(wq, skb,
                                dma_addr,
                                len,
index a0a6471..32db4c8 100644 (file)
@@ -2777,7 +2777,7 @@ static netdev_tx_t skge_xmit_frame(struct sk_buff *skb,
                        skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 
                        map = skb_frag_dma_map(&hw->pdev->dev, frag, 0,
-                                              frag->size, PCI_DMA_TODEVICE);
+                                              frag->size, DMA_TO_DEVICE);
 
                        e = e->next;
                        e->skb = skb;
index 338b10c..a3ce9b6 100644 (file)
@@ -1229,9 +1229,9 @@ static int sky2_rx_map_skb(struct pci_dev *pdev, struct rx_ring_info *re,
 
                re->frag_addr[i] = skb_frag_dma_map(&pdev->dev, frag, 0,
                                                    frag->size,
-                                                   PCI_DMA_FROMDEVICE);
+                                                   DMA_FROM_DEVICE);
 
-               if (pci_dma_mapping_error(pdev, re->frag_addr[i]))
+               if (dma_mapping_error(&pdev->dev, re->frag_addr[i]))
                        goto map_page_error;
        }
        return 0;
@@ -1936,9 +1936,9 @@ static netdev_tx_t sky2_xmit_frame(struct sk_buff *skb,
                const skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 
                mapping = skb_frag_dma_map(&hw->pdev->dev, frag, 0,
-                                          frag->size, PCI_DMA_TODEVICE);
+                                          frag->size, DMA_TO_DEVICE);
 
-               if (pci_dma_mapping_error(hw->pdev, mapping))
+               if (dma_mapping_error(&hw->pdev->dev, mapping))
                        goto mapping_unwind;
 
                upper = upper_32_bits(mapping);
index 8bf6034..2663727 100644 (file)
@@ -2928,7 +2928,7 @@ again:
                frag_idx++;
                len = frag->size;
                bus = skb_frag_dma_map(&mgp->pdev->dev, frag, 0, len,
-                                      PCI_DMA_TODEVICE);
+                                      DMA_TO_DEVICE);
                dma_unmap_addr_set(&tx->info[idx], bus, bus);
                dma_unmap_len_set(&tx->info[idx], len, len);
        }
index e0895e4..73616b9 100644 (file)
@@ -1161,7 +1161,7 @@ again:
                        break;
 
                buf = skb_frag_dma_map(&dev->pci_dev->dev, frag, 0,
-                                      frag->size, PCI_DMA_TODEVICE);
+                                      frag->size, DMA_TO_DEVICE);
                dprintk("frag: buf=%08Lx  page=%08lx offset=%08lx\n",
                        (long long)buf, (long) page_to_pfn(frag->page),
                        frag->page_offset);
index ef5b825..4ec7e3f 100644 (file)
@@ -4193,7 +4193,7 @@ static netdev_tx_t s2io_xmit(struct sk_buff *skb, struct net_device *dev)
                txdp->Buffer_Pointer = (u64)skb_frag_dma_map(&sp->pdev->dev,
                                                             frag, 0,
                                                             frag->size,
-                                                            PCI_DMA_TODEVICE);
+                                                            DMA_TO_DEVICE);
                txdp->Control_1 = TXD_BUFFER0_SIZE(frag->size);
                if (offload_type == SKB_GSO_UDP)
                        txdp->Control_1 |= TXD_UFO_EN;
index 4e39b8c..84baa59 100644 (file)
@@ -2150,7 +2150,7 @@ static netdev_tx_t nv_start_xmit(struct sk_buff *skb, struct net_device *dev)
                                                        &np->pci_dev->dev,
                                                        frag, offset,
                                                        bcnt,
-                                                       PCI_DMA_TODEVICE);
+                                                       DMA_TO_DEVICE);
                        np->put_tx_ctx->dma_len = bcnt;
                        np->put_tx_ctx->dma_single = 0;
                        put_tx->buf = cpu_to_le32(np->put_tx_ctx->dma);
@@ -2264,7 +2264,7 @@ static netdev_tx_t nv_start_xmit_optimized(struct sk_buff *skb,
                                                        &np->pci_dev->dev,
                                                        frag, offset,
                                                        bcnt,
-                                                       PCI_DMA_TODEVICE);
+                                                       DMA_TO_DEVICE);
                        np->put_tx_ctx->dma_len = bcnt;
                        np->put_tx_ctx->dma_single = 0;
                        put_tx->bufhigh = cpu_to_le32(dma_high(np->put_tx_ctx->dma));
index 5322095..c6f0056 100644 (file)
@@ -1506,9 +1506,9 @@ static int pasemi_mac_start_tx(struct sk_buff *skb, struct net_device *dev)
                skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
 
                map[i + 1] = skb_frag_dma_map(&mac->dma_pdev->dev, frag, 0,
-                                             frag->size, PCI_DMA_TODEVICE);
+                                             frag->size, DMA_TO_DEVICE);
                map_size[i+1] = frag->size;
-               if (pci_dma_mapping_error(mac->dma_pdev, map[i+1])) {
+               if (dma_mapping_error(&mac->dma_pdev->dev, map[i + 1])) {
                        nfrags = i;
                        goto out_err_nolock;
                }
index dc9e21a..e2ba78b 100644 (file)
@@ -1906,8 +1906,8 @@ netxen_map_tx_skb(struct pci_dev *pdev,
                nf = &pbuf->frag_array[i+1];
 
                map = skb_frag_dma_map(&pdev->dev, frag, 0, frag->size,
-                                      PCI_DMA_TODEVICE);
-               if (pci_dma_mapping_error(pdev, map))
+                                      DMA_TO_DEVICE);
+               if (dma_mapping_error(&pdev->dev, map))
                        goto unwind;
 
                nf->dma = map;
index 1871d88..46f9b64 100644 (file)
@@ -2389,9 +2389,9 @@ static int ql_send_map(struct ql3_adapter *qdev,
                }
 
                map = skb_frag_dma_map(&qdev->pdev->dev, frag, 0, frag->size,
-                                      PCI_DMA_TODEVICE);
+                                      DMA_TO_DEVICE);
 
-               err = pci_dma_mapping_error(qdev->pdev, map);
+               err = dma_mapping_error(&qdev->pdev->dev, map);
                if (err) {
                        netdev_err(qdev->ndev,
                                   "PCI mapping frags failed with error: %d\n",
index 445956e..eac19e7 100644 (file)
@@ -2136,8 +2136,8 @@ qlcnic_map_tx_skb(struct pci_dev *pdev,
                nf = &pbuf->frag_array[i+1];
 
                map = skb_frag_dma_map(&pdev->dev, frag, 0, frag->size,
-                                      PCI_DMA_TODEVICE);
-               if (pci_dma_mapping_error(pdev, map))
+                                      DMA_TO_DEVICE);
+               if (dma_mapping_error(&pdev->dev, map))
                        goto unwind;
 
                nf->dma = map;
index ce6c6fe..f2d9bb7 100644 (file)
@@ -1432,9 +1432,9 @@ static int ql_map_send(struct ql_adapter *qdev,
                }
 
                map = skb_frag_dma_map(&qdev->pdev->dev, frag, 0, frag->size,
-                                      PCI_DMA_TODEVICE);
+                                      DMA_TO_DEVICE);
 
-               err = pci_dma_mapping_error(qdev->pdev, map);
+               err = dma_mapping_error(&qdev->pdev->dev, map);
                if (err) {
                        netif_err(qdev, tx_queued, qdev->ndev,
                                  "PCI mapping frags failed with error: %d.\n",
index f2467a1..3964a62 100644 (file)
@@ -243,7 +243,7 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
                /* Map for DMA */
                unmap_single = false;
                dma_addr = skb_frag_dma_map(&pci_dev->dev, fragment, 0, len,
-                                           PCI_DMA_TODEVICE);
+                                           DMA_TO_DEVICE);
        }
 
        /* Transfer ownership of the skb to the final buffer */
@@ -926,8 +926,8 @@ static int tso_get_fragment(struct tso_state *st, struct efx_nic *efx,
                            skb_frag_t *frag)
 {
        st->unmap_addr = skb_frag_dma_map(&efx->pci_dev->dev, frag, 0,
-                                         frag->size, PCI_DMA_TODEVICE);
-       if (likely(!pci_dma_mapping_error(efx->pci_dev, st->unmap_addr))) {
+                                         frag->size, DMA_TO_DEVICE);
+       if (likely(!dma_mapping_error(&efx->pci_dev->dev, st->unmap_addr))) {
                st->unmap_single = false;
                st->unmap_len = frag->size;
                st->in_len = frag->size;
index 1206821..d9460d8 100644 (file)
@@ -2830,7 +2830,7 @@ static inline int cas_xmit_tx_ringN(struct cas *cp, int ring,
 
                len = fragp->size;
                mapping = skb_frag_dma_map(&cp->pdev->dev, fragp, 0, len,
-                                          PCI_DMA_TODEVICE);
+                                          DMA_TO_DEVICE);
 
                tabort = cas_calc_tabort(cp, fragp->page_offset, len);
                if (unlikely(tabort)) {
index 2bfa171..6b62a73 100644 (file)
@@ -1072,7 +1072,7 @@ static netdev_tx_t gem_start_xmit(struct sk_buff *skb,
 
                        len = this_frag->size;
                        mapping = skb_frag_dma_map(&gp->pdev->dev, this_frag,
-                                                  0, len, PCI_DMA_TODEVICE);
+                                                  0, len, DMA_TO_DEVICE);
                        this_ctrl = ctrl;
                        if (frag == skb_shinfo(skb)->nr_frags - 1)
                                this_ctrl |= TXDCTRL_EOF;
index 1151cf9..c77e3bf 100644 (file)
@@ -1499,7 +1499,7 @@ bdx_tx_map_skb(struct bdx_priv *priv, struct sk_buff *skb,
                db->wptr->len = frag->size;
                db->wptr->addr.dma = skb_frag_dma_map(&priv->pdev->dev, frag,
                                                      0, frag->size,
-                                                     PCI_DMA_TODEVICE);
+                                                     DMA_TO_DEVICE);
 
                pbl++;
                pbl->len = CPU_CHIP_SWAP32(db->wptr->len);
index 1ec32c4..b47bce1 100644 (file)
@@ -2559,7 +2559,7 @@ static netdev_tx_t velocity_xmit(struct sk_buff *skb,
                tdinfo->skb_dma[i + 1] = skb_frag_dma_map(&vptr->pdev->dev,
                                                          frag, 0,
                                                          frag->size,
-                                                         PCI_DMA_TODEVICE);
+                                                         DMA_TO_DEVICE);
 
                td_ptr->td_buf[i + 1].pa_low = cpu_to_le32(tdinfo->skb_dma[i + 1]);
                td_ptr->td_buf[i + 1].pa_high = 0;
index 57e7c66..1694038 100644 (file)
@@ -750,7 +750,7 @@ vmxnet3_map_pkt(struct sk_buff *skb, struct vmxnet3_tx_ctx *ctx,
                tbi->map_type = VMXNET3_MAP_PAGE;
                tbi->dma_addr = skb_frag_dma_map(&adapter->pdev->dev, frag,
                                                 0, frag->size,
-                                                PCI_DMA_TODEVICE);
+                                                DMA_TO_DEVICE);
 
                tbi->len = frag->size;
 
index 03e7a4e..e4f51e6 100644 (file)
@@ -524,7 +524,7 @@ static int nic_send_packet(struct et131x_adapter *etdev, struct tcb *tcb)
                                                        &frags[i - 1],
                                                        0,
                                                        frags[i - 1].size,
-                                                       PCI_DMA_TODEVICE);
+                                                       DMA_TO_DEVICE);
                }
        }