Fix memleak on keys with more than one user id

- This is not "correct", we should permit more than one user id.
  Leaking memory is still worse than not leaking, corrent behavior
  or not.

diff --git a/rpmio/rpmpgp.c b/rpmio/rpmpgp.c
index ebd126c..01e74e4 100644 (file)
--- a/rpmio/rpmpgp.c
+++ b/rpmio/rpmpgp.c
@@ -1044,9 +1044,9 @@ static int pgpPrtUserID(pgpTag tag, const uint8_t *h, size_t hlen,
        fprintf(stderr, " \"%.*s\"", (int)hlen, (const char *)h);
     pgpPrtNL();
     if (_digp) {
-       char * t;
-       _digp->userid = t = memcpy(xmalloc(hlen+1), h, hlen);
-       t[hlen] = '\0';
+       free(_digp->userid);
+       _digp->userid = memcpy(xmalloc(hlen+1), h, hlen);
+       _digp->userid[hlen] = '\0';
     }
     return 0;
 }