Bluetooth: Delete error messages for failed memory allocations in two functions
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 22 May 2017 06:42:28 +0000 (08:42 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 22 May 2017 08:23:41 +0000 (10:23 +0200)
Omit two extra messages for memory allocation failures in these functions.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/ecdh_helper.c

index 24d4e60..c7b1a9a 100644 (file)
@@ -89,11 +89,9 @@ bool compute_ecdh_secret(const u8 public_key[64], const u8 private_key[32],
        p.curve_id = ECC_CURVE_NIST_P256;
        buf_len = crypto_ecdh_key_len(&p);
        buf = kmalloc(buf_len, GFP_KERNEL);
-       if (!buf) {
-               pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",
-                      buf_len);
+       if (!buf)
                goto free_req;
-       }
+
        crypto_ecdh_encode_key(buf, buf_len, &p);
 
        /* Set A private Key */
@@ -170,11 +168,8 @@ bool generate_ecdh_keys(u8 public_key[64], u8 private_key[32])
        p.key_size = 32;
        buf_len = crypto_ecdh_key_len(&p);
        buf = kmalloc(buf_len, GFP_KERNEL);
-       if (!buf) {
-               pr_err("alg: kpp: Failed to allocate %d bytes for buf\n",
-                      buf_len);
+       if (!buf)
                goto free_req;
-       }
 
        do {
                if (tries++ >= max_tries)