iwlwifi: mvm: reset seq num after restart
authorLiad Kaufman <liad.kaufman@intel.com>
Tue, 17 Oct 2017 13:26:00 +0000 (16:26 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 3 Nov 2017 09:56:08 +0000 (11:56 +0200)
After a FW reset on A000 NICs, the driver doesn't
set the seq number when re-allocating the queues.
This in turn leads to a mismatch between the seq
number the driver thinks each frame has, and the
actual seq num given by the HW.

This especially causes issues with aggregations,
since the driver could be waiting to start an
aggregation and queue traffic from the mac80211
until then, when actually it shouldn't be waiting.

Fixes: 310181ec34e2 ("iwlwifi: move to TVQM mode")
Signed-off-by: Liad Kaufman <liad.kaufman@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/sta.c

index c8febde..039efcd 100644 (file)
@@ -1257,6 +1257,14 @@ static void iwl_mvm_realloc_queues_after_restart(struct iwl_mvm *mvm,
                                                         mvm_sta->sta_id,
                                                         i, wdg_timeout);
                        tid_data->txq_id = txq_id;
+
+                       /*
+                        * Since we don't set the seq number after reset, and HW
+                        * sets it now, FW reset will cause the seq num to start
+                        * at 0 again, so driver will need to update it
+                        * internally as well, so it keeps in sync with real val
+                        */
+                       tid_data->seq_number = 0;
                } else {
                        u16 seq = IEEE80211_SEQ_TO_SN(tid_data->seq_number);