media: s5p-g2d: Fix a memory leak on ctx->fh.m2m_ctx
authorDillon Min <dillon.minfei@gmail.com>
Wed, 26 May 2021 15:18:32 +0000 (17:18 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 17 Jun 2021 08:21:51 +0000 (10:21 +0200)
The m2m_ctx resources was allocated by v4l2_m2m_ctx_init() in g2d_open()
should be freed from g2d_release() when it's not used.

Fix it

Fixes: 918847341af0 ("[media] v4l: add G2D driver for s5p device family")
Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/s5p-g2d/g2d.c

index 15bcb7f..1cb5eaa 100644 (file)
@@ -276,6 +276,9 @@ static int g2d_release(struct file *file)
        struct g2d_dev *dev = video_drvdata(file);
        struct g2d_ctx *ctx = fh2ctx(file->private_data);
 
+       mutex_lock(&dev->mutex);
+       v4l2_m2m_ctx_release(ctx->fh.m2m_ctx);
+       mutex_unlock(&dev->mutex);
        v4l2_ctrl_handler_free(&ctx->ctrl_handler);
        v4l2_fh_del(&ctx->fh);
        v4l2_fh_exit(&ctx->fh);