mfd: pm8921: Remove unnecessary platform_set_drvdata()
authorJingoo Han <jg1.han@samsung.com>
Tue, 20 Aug 2013 07:02:05 +0000 (16:02 +0900)
committerLee Jones <lee.jones@linaro.org>
Tue, 20 Aug 2013 07:50:54 +0000 (08:50 +0100)
The driver core clears the driver data to NULL after device_release
or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound).
Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/pm8921-core.c

index bd4b37c..9a7c991 100644 (file)
@@ -160,7 +160,6 @@ static int pm8921_probe(struct platform_device *pdev)
 
 err:
        mfd_remove_devices(pmic->dev);
-       platform_set_drvdata(pdev, NULL);
 err_read_rev:
        kfree(pmic);
        return rc;
@@ -180,7 +179,6 @@ static int pm8921_remove(struct platform_device *pdev)
                pm8xxx_irq_exit(pmic->irq_chip);
                pmic->irq_chip = NULL;
        }
-       platform_set_drvdata(pdev, NULL);
        kfree(pmic);
 
        return 0;