radv: re-emit dynamic depth clamp enable if depth clip enable changed
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Fri, 18 Nov 2022 08:50:40 +0000 (09:50 +0100)
committerEric Engestrom <eric@engestrom.ch>
Wed, 30 Nov 2022 21:12:42 +0000 (21:12 +0000)
The depth clamp mode depends on depth clip enable/disable.

Fixes: e48c0fbd8f7 ("radv: add support for dynamic depth clamp enable")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19843>
(cherry picked from commit de4de09a56c421ec1194dea016c3b9ef80abbb83)

.pick_status.json
src/amd/vulkan/radv_cmd_buffer.c

index ea7017e..a98413a 100644 (file)
         "description": "radv: re-emit dynamic depth clamp enable if depth clip enable changed",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": "e48c0fbd8f70df5f74bdbe594f807d09fc3a4424"
     },
index a1ba90f..ad405cd 100644 (file)
@@ -3587,7 +3587,8 @@ radv_cmd_buffer_flush_dynamic_state(struct radv_cmd_buffer *cmd_buffer, bool pip
    if (states & RADV_CMD_DIRTY_DYNAMIC_SAMPLE_MASK)
       radv_emit_sample_mask(cmd_buffer);
 
-   if (states & RADV_CMD_DIRTY_DYNAMIC_DEPTH_CLAMP_ENABLE)
+   if (states & (RADV_CMD_DIRTY_DYNAMIC_DEPTH_CLAMP_ENABLE |
+                 RADV_CMD_DIRTY_DYNAMIC_DEPTH_CLIP_ENABLE))
       radv_emit_depth_clamp_enable(cmd_buffer);
 
    cmd_buffer->state.dirty &= ~states;