Fix for issues reported on SVACE tool for PKIX

Fixed issues reported on running svace analysis to PKIX

Change-Id: I84af37b59c45061371ead13a5adc990aa8e8a755
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/5299
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

diff --git a/resource/csdk/connectivity/src/adapter_util/pkix/der_dec.c b/resource/csdk/connectivity/src/adapter_util/pkix/der_dec.c
index a1c5bba..06e46b9 100644 (file)
--- a/resource/csdk/connectivity/src/adapter_util/pkix/der_dec.c
+++ b/resource/csdk/connectivity/src/adapter_util/pkix/der_dec.c
@@ -46,7 +46,7 @@ PKIError DecodeLength(ByteArray *code, size_t *length)
 
         for (i = 0; i < blocksNum; ++i)
         {
-            *length |= *(code->data) << ((blocksNum - i - 1) * SIZE_OF_BYTE);
+            *length |= (size_t) (((size_t) *(code->data)) << ((blocksNum - i - 1) * SIZE_OF_BYTE));
             CHECK_INC_BYTE_ARRAY_PTR(code, 1);
         }
     }

diff --git a/resource/csdk/connectivity/src/adapter_util/pkix/sn_store.c b/resource/csdk/connectivity/src/adapter_util/pkix/sn_store.c
index b393fbb..3eff6c9 100644 (file)
--- a/resource/csdk/connectivity/src/adapter_util/pkix/sn_store.c
+++ b/resource/csdk/connectivity/src/adapter_util/pkix/sn_store.c
@@ -82,7 +82,8 @@ PKIError StoreSerialNumber(const ByteArray sn)
 PKIError CheckSerialNumber(const ByteArray sn)
 {
     FUNCTION_INIT(
-        int i, res;
+        unsigned long int i;
+        int res;
         CHECK_NULL(sn.data, PKI_NULL_PASSED);
     );
     CHECK_NULL(Store.array.data, PKI_SUCCESS);