[logcleanup] Fix svace/coverity issue

- check return value

Change-Id: Ie861d6972c3bfa2c8346f8a25e72e0039e344e6e
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>

diff --git a/src/logcleanup/cleanup.c b/src/logcleanup/cleanup.c
index 1cae8d3..48bc594 100644 (file)
--- a/src/logcleanup/cleanup.c
+++ b/src/logcleanup/cleanup.c
@@ -28,20 +28,19 @@
 
 static int cleanup_recursive(const char *path)
 {
-       int ret;
+       int ret = 0;
        struct stat f;
        DIR *dir = NULL;
        struct dirent *dent;
        char sub_path[PATH_MAX] = {0,};
 
-       ret = lstat(path, &f);
-       if (ret)
+       if (access(path, W_OK) < 0)
                return -EINVAL;
 
-       if ((f.st_mode & S_IFMT) == S_IFDIR) {
-               if (access(path, W_OK) != 0)
-                       return -EINVAL;
+       if (lstat(path, &f) < 0)
+               return -EINVAL;
 
+       if ((f.st_mode & S_IFMT) == S_IFDIR) {
                dir = opendir(path);
                if (!dir)
                        return -EINVAL;
@@ -60,7 +59,6 @@ static int cleanup_recursive(const char *path)
                                break;
                }
                closedir(dir);
-               return ret;
        } else {
                regex_t regex;
 
@@ -68,12 +66,14 @@ static int cleanup_recursive(const char *path)
                if (ret)
                        return -EINVAL;
 
-               if (!regexec(&regex, path, 0, NULL, 0))
-                       remove(path);
+               if (!regexec(&regex, path, 0, NULL, 0)) {
+                       if (remove(path) < 0)
+                               ret = -errno;
+               }
 
                regfree(&regex);
        }
-       return 0;
+       return ret;
 }
 
 int main(int argc, char *argv[])