staging: erofs: clean up initialization of pointer de
authorColin Ian King <colin.king@canonical.com>
Mon, 17 Jun 2019 12:55:29 +0000 (13:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2019 06:59:40 +0000 (08:59 +0200)
Currently pointer de is being initialized with a value that is
never read and a few statements later de is being re-assigned. Clean
this up by ininitialzing de and removing the re-assignment.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/erofs/dir.c

index 9bbc687..dbf6a15 100644 (file)
@@ -42,10 +42,9 @@ static int erofs_fill_dentries(struct dir_context *ctx,
                               void *dentry_blk, unsigned int *ofs,
                               unsigned int nameoff, unsigned int maxsize)
 {
-       struct erofs_dirent *de = dentry_blk;
+       struct erofs_dirent *de = dentry_blk + *ofs;
        const struct erofs_dirent *end = dentry_blk + nameoff;
 
-       de = dentry_blk + *ofs;
        while (de < end) {
                const char *de_name;
                unsigned int de_namelen;