[NFC] Clarify comment about LoopDeletionPass in the optimization pipeline
authorArthur Eubanks <aeubanks@google.com>
Mon, 6 Dec 2021 21:04:57 +0000 (13:04 -0800)
committerArthur Eubanks <aeubanks@google.com>
Tue, 7 Dec 2021 17:58:12 +0000 (09:58 -0800)
Reviewed By: lebedev.ri

Differential Revision: https://reviews.llvm.org/D115179

llvm/lib/Passes/PassBuilderPipelines.cpp

index 490c698..dbfa2a4 100644 (file)
@@ -1164,8 +1164,9 @@ PassBuilder::buildModuleOptimizationPipeline(OptimizationLevel Level,
   // Disable header duplication at -Oz.
   LPM.addPass(LoopRotatePass(Level != OptimizationLevel::Oz, LTOPreLink));
   // Some loops may have become dead by now. Try to delete them.
-  // FIXME: see disscussion in https://reviews.llvm.org/D112851
-  //        this may need to be revisited once GVN is more powerful.
+  // FIXME: see discussion in https://reviews.llvm.org/D112851,
+  //        this may need to be revisited once we run GVN before loop deletion
+  //        in the simplification pipeline.
   LPM.addPass(LoopDeletionPass());
   OptimizePM.addPass(createFunctionToLoopPassAdaptor(
       std::move(LPM), /*UseMemorySSA=*/false, /*UseBlockFrequencyInfo=*/false));