ALSA: ppc: drop if block with always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thu, 26 Nov 2020 16:59:49 +0000 (17:59 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 28 Nov 2020 08:47:09 +0000 (09:47 +0100)
The remove callback is only called for devices that were probed
successfully before. As the matching probe function cannot complete
without error if dev->match_id != PS3_MATCH_ID_SOUND, we don't have to
check this here.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Geoff Levand <geoff@infradead.org>
Link: https://lore.kernel.org/r/20201126165950.2554997-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/snd_ps3.c

index 58bb49f..6ab796a 100644 (file)
@@ -1053,8 +1053,6 @@ static int snd_ps3_driver_remove(struct ps3_system_bus_device *dev)
 {
        int ret;
        pr_info("%s:start id=%d\n", __func__,  dev->match_id);
-       if (dev->match_id != PS3_MATCH_ID_SOUND)
-               return -ENXIO;
 
        /*
         * ctl and preallocate buffer will be freed in