staging: wilc1000: removes goto definitions from wilc_wlan_firmware_download
authorLeo Kim <leo.kim@atmel.com>
Tue, 15 Mar 2016 09:48:13 +0000 (18:48 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2016 14:30:36 +0000 (07:30 -0700)
This patch removes goto definitions from wilc_wlan_firmware_download function.
Goto '_fail_1' feature is error return.
It returns error type directly without result variable replacement as well.

Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wilc1000/wilc_wlan.c

index ca9054a..ea671a9 100644 (file)
@@ -946,10 +946,8 @@ int wilc_wlan_firmware_download(struct wilc *wilc, const u8 *buffer,
        blksz = BIT(12);
 
        dma_buffer = kmalloc(blksz, GFP_KERNEL);
-       if (!dma_buffer) {
-               ret = -EIO;
-               goto _fail_1;
-       }
+       if (!dma_buffer)
+               return -EIO;
 
        offset = 0;
        do {
@@ -987,8 +985,6 @@ _fail_:
 
        kfree(dma_buffer);
 
-_fail_1:
-
        return (ret < 0) ? ret : 0;
 }