riscv: stacktrace: Fixup ftrace_graph_ret_addr retp argument
authorGuo Ren <guoren@linux.alibaba.com>
Wed, 9 Nov 2022 06:49:36 +0000 (01:49 -0500)
committerPalmer Dabbelt <palmer@rivosinc.com>
Tue, 6 Dec 2022 00:58:01 +0000 (16:58 -0800)
The 'retp' is a pointer to the return address on the stack, so we
must pass the current return address pointer as the 'retp'
argument to ftrace_push_return_trace(). Not parent function's
return address on the stack.

Fixes: b785ec129bd9 ("riscv/ftrace: Add HAVE_FUNCTION_GRAPH_RET_ADDR_PTR support")
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Signed-off-by: Guo Ren <guoren@kernel.org>
Link: https://lore.kernel.org/r/20221109064937.3643993-2-guoren@kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
arch/riscv/kernel/stacktrace.c

index 08d11a5..bcfe9eb 100644 (file)
@@ -58,7 +58,7 @@ void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs,
                } else {
                        fp = frame->fp;
                        pc = ftrace_graph_ret_addr(current, NULL, frame->ra,
-                                                  (unsigned long *)(fp - 8));
+                                                  &frame->ra);
                }
 
        }