oggdemux: Don't leak incoming EOS event
authorEdward Hervey <edward@centricular.com>
Mon, 14 Nov 2022 06:26:25 +0000 (07:26 +0100)
committerGStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org>
Mon, 14 Nov 2022 16:51:40 +0000 (16:51 +0000)
If we're going to drop it ... then do drop it :)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3400>

subprojects/gst-plugins-base/ext/ogg/gstoggdemux.c

index 649f63d..d088d64 100644 (file)
@@ -2524,6 +2524,7 @@ gst_ogg_demux_sink_event (GstPad * pad, GstObject * parent, GstEvent * event)
           GST_DEBUG_OBJECT (ogg, "Error seeking back after duration check: %d",
               res);
         }
+        gst_event_unref (event);
         res = TRUE;
         break;
       } else {
@@ -2538,6 +2539,8 @@ gst_ogg_demux_sink_event (GstPad * pad, GstObject * parent, GstEvent * event)
       }
       if (!drop)
         res = gst_ogg_demux_send_event (ogg, event);
+      else
+        gst_event_unref (event);
       if (ogg->current_chain == NULL) {
         GST_WARNING_OBJECT (ogg,
             "EOS while trying to retrieve chain, seeking disabled");