CoreAudio: Mismatched new[]/delete in several places.
authorDyami Caliri <dyami@dragonframe.com>
Thu, 27 Mar 2014 16:29:38 +0000 (09:29 -0700)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Thu, 27 Mar 2014 17:01:09 +0000 (18:01 +0100)
The CoreAudio plugin code in QtMultimedia had several different places
where an array was allocated with "new[]" and deleted with "delete".
Fixed by deleting with "delete[]".

Task-number: QTBUG-37861
Change-Id: Id85bc07a054ad161b0403cc0fe5c56ec5b41d4e3
Reviewed-by: Andy Nichols <andy.nichols@digia.com>
src/plugins/coreaudio/coreaudiodeviceinfo.mm
src/plugins/coreaudio/coreaudioutils.mm

index 74a692c..56765ca 100644 (file)
@@ -110,7 +110,7 @@ QAudioFormat CoreAudioDeviceInfo::preferredFormat() const
                 }
             }
 
-            delete streams;
+            delete[] streams;
         }
     }
 #else //iOS
@@ -180,7 +180,7 @@ QList<int> CoreAudioDeviceInfo::supportedSampleRates()
                 }
             }
 
-            delete vr;
+            delete[] vr;
         }
     }
 #else //iOS
@@ -380,7 +380,7 @@ QList<QByteArray> CoreAudioDeviceInfo::availableDevices(QAudio::Mode mode)
                 }
             }
 
-            delete audioDevices;
+            delete[] audioDevices;
         }
     }
 #else //iOS
index d43303a..e626561 100644 (file)
@@ -125,7 +125,7 @@ CoreAudioRingBuffer::CoreAudioRingBuffer(int bufferSize):
 
 CoreAudioRingBuffer::~CoreAudioRingBuffer()
 {
-    delete m_buffer;
+    delete[] m_buffer;
 }
 
 CoreAudioRingBuffer::Region CoreAudioRingBuffer::acquireReadRegion(int size)