staging: r8188eu: relay errors from ODM_ReadAndConfig_...
authorMartin Kaiser <martin@kaiser.cx>
Mon, 10 Jan 2022 12:46:35 +0000 (13:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 25 Jan 2022 15:18:42 +0000 (16:18 +0100)
Most of the ODM_ReadAndConfig_... functions return an error status.
Update their callers to process these return values.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220110124638.6909-7-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/odm_HWConfig.c

index 2f07524..5ec9a04 100644 (file)
@@ -360,22 +360,22 @@ void ODM_PhyStatusQuery(struct odm_dm_struct *dm_odm,
 
 enum HAL_STATUS ODM_ConfigRFWithHeaderFile(struct odm_dm_struct *dm_odm)
 {
-       ODM_ReadAndConfig_RadioA_1T_8188E(dm_odm);
-
-       return HAL_STATUS_SUCCESS;
+       return ODM_ReadAndConfig_RadioA_1T_8188E(dm_odm);
 }
 
 enum HAL_STATUS ODM_ConfigBBWithHeaderFile(struct odm_dm_struct *dm_odm,
                                           enum odm_bb_config_type config_tp)
 {
-       if (config_tp == CONFIG_BB_PHY_REG)
-               ODM_ReadAndConfig_PHY_REG_1T_8188E(dm_odm);
-       else if (config_tp == CONFIG_BB_AGC_TAB)
-               ODM_ReadAndConfig_AGC_TAB_1T_8188E(dm_odm);
-       else if (config_tp == CONFIG_BB_PHY_REG_PG)
+       if (config_tp == CONFIG_BB_PHY_REG) {
+               return ODM_ReadAndConfig_PHY_REG_1T_8188E(dm_odm);
+       } else if (config_tp == CONFIG_BB_AGC_TAB) {
+               return ODM_ReadAndConfig_AGC_TAB_1T_8188E(dm_odm);
+       } else if (config_tp == CONFIG_BB_PHY_REG_PG) {
                ODM_ReadAndConfig_PHY_REG_PG_8188E(dm_odm);
+               return HAL_STATUS_SUCCESS;
+       }
 
-       return HAL_STATUS_SUCCESS;
+       return HAL_STATUS_FAILURE;
 }
 
 enum HAL_STATUS ODM_ConfigMACWithHeaderFile(struct odm_dm_struct *dm_odm)