serial: sc16is7xx: improve do/while loop in sc16is7xx_irq()

commit d5078509c8b06c5c472a60232815e41af81c6446 upstream.

Simplify and improve readability by replacing while(1) loop with
do {} while, and by using the keep_polling variable as the exit
condition, making it more explicit.

Fixes: 834449872105 ("sc16is7xx: Fix for multi-channel stall")
Cc:  <stable@vger.kernel.org>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20231221231823.2327894-6-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 910870c..3276d21 100644 (file)
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -782,17 +782,18 @@ out_port_irq:
 
 static irqreturn_t sc16is7xx_irq(int irq, void *dev_id)
 {
+       bool keep_polling;
+
        struct sc16is7xx_port *s = (struct sc16is7xx_port *)dev_id;
 
-       while (1) {
-               bool keep_polling = false;
+       do {
                int i;
 
+               keep_polling = false;
+
                for (i = 0; i < s->devtype->nr_uart; ++i)
                        keep_polling |= sc16is7xx_port_irq(s, i);
-               if (!keep_polling)
-                       break;
-       }
+       } while (keep_polling);
 
        return IRQ_HANDLED;
 }