Always drop SEM_NOGPFAULTERRORBOX flag from error mode (enables WER if crashReporter...
authorMilan Burda <milan.burda@gmail.com>
Thu, 29 Sep 2016 20:57:41 +0000 (13:57 -0700)
committerMilan Burda <milan.burda@gmail.com>
Thu, 29 Sep 2016 20:57:41 +0000 (13:57 -0700)
atom/common/node_bindings.cc

index 1e3fac3874f3aa7c9ad8bdbca55fc1dc1dad5c04..a049be23a67e671054ffaba6acbb5686d8f021b7 100644 (file)
@@ -144,7 +144,7 @@ void NodeBindings::Initialize() {
   // uv_init overrides error mode to suppress the default crash dialog, bring
   // it back if user wants to show it.
   std::unique_ptr<base::Environment> env(base::Environment::Create());
-  if (env->HasVar("ELECTRON_DEFAULT_ERROR_MODE"))
+  if (is_browser_ || env->HasVar("ELECTRON_DEFAULT_ERROR_MODE"))
     SetErrorMode(GetErrorMode() & ~SEM_NOGPFAULTERRORBOX);
 #endif
 }