Fix Clang warning about copy elision

Found by Clang 3.7:

qcommandlineoption.cpp:287:12: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]

Change-Id: I7de033f80b0e4431b7f1ffff13f97fb480001d36
Reviewed-by: David Faure <david.faure@kdab.com>

diff --git a/src/corelib/tools/qcommandlineoption.cpp b/src/corelib/tools/qcommandlineoption.cpp
index eb50cee5bb8f31e9aae3a3103aa1a84efb60e1ad..5eda114087fd56580a71511572dbdd8ed1f27e7c 100644 (file)
--- a/src/corelib/tools/qcommandlineoption.cpp
+++ b/src/corelib/tools/qcommandlineoption.cpp
@@ -284,7 +284,7 @@ QStringList QCommandLineOptionPrivate::removeInvalidNames(QStringList nameList)
     else
         nameList.erase(std::remove_if(nameList.begin(), nameList.end(), IsInvalidName()),
                        nameList.end());
-    return qMove(nameList);
+    return nameList;
 }
 
 /*!