Don't gc protected symbols.
authorRafael Espindola <rafael.espindola@gmail.com>
Thu, 21 Apr 2016 23:59:19 +0000 (23:59 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Thu, 21 Apr 2016 23:59:19 +0000 (23:59 +0000)
llvm-svn: 267081

lld/ELF/MarkLive.cpp
lld/test/ELF/gc-sections-protected.s [new file with mode: 0644]

index 155fe3f..cbc5fd2 100644 (file)
@@ -116,7 +116,7 @@ template <class ELFT> void elf::markLive(SymbolTable<ELFT> *Symtab) {
   if (Config->Shared || Config->ExportDynamic) {
     for (const Symbol *S : Symtab->getSymbols()) {
       SymbolBody *B = S->Body;
-      if (B->getVisibility() == STV_DEFAULT)
+      if (B->includeInDynsym())
         MarkSymbol(B);
     }
   }
diff --git a/lld/test/ELF/gc-sections-protected.s b/lld/test/ELF/gc-sections-protected.s
new file mode 100644 (file)
index 0000000..9f1efed
--- /dev/null
@@ -0,0 +1,18 @@
+// RUN: llvm-mc %s -o %t.o -filetype=obj -triple=x86_64-pc-linux
+// RUN: ld.lld %t.o -o %t.so -shared --gc-sections
+// RUN: llvm-readobj -s %t.so | FileCheck %s
+
+// CHECK:      Name: .text
+// CHECK-NEXT: Type: SHT_PROGBITS
+// CHECK-NEXT: Flags [
+// CHECK-NEXT:   SHF_ALLOC
+// CHECK-NEXT:   SHF_EXECINSTR
+// CHECK-NEXT: ]
+// CHECK-NEXT: Address:
+// CHECK-NEXT: Offset:
+// CHECK-NEXT: Size: 1
+
+.protected g
+.globl g
+g:
+retq