Return -1 for failing to enable/disable bits
authorPeter Hutterer <peter.hutterer@who-t.net>
Sat, 29 Jun 2013 07:34:32 +0000 (17:34 +1000)
committerPeter Hutterer <peter.hutterer@who-t.net>
Sat, 29 Jun 2013 07:52:06 +0000 (17:52 +1000)
as the documentation says

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
libevdev/libevdev.c

index fd3d3c7..d4cebc6 100644 (file)
@@ -785,7 +785,7 @@ int
 libevdev_enable_event_type(struct libevdev *dev, unsigned int type)
 {
        if (type > EV_MAX)
-               return 1;
+               return -1;
 
        set_bit(dev->bits, type);
 
@@ -796,7 +796,7 @@ int
 libevdev_disable_event_type(struct libevdev *dev, unsigned int type)
 {
        if (type > EV_MAX)
-               return 1;
+               return -1;
 
        clear_bit(dev->bits, type);
 
@@ -811,12 +811,12 @@ libevdev_enable_event_code(struct libevdev *dev, unsigned int type,
        unsigned long *mask;
 
        if (libevdev_enable_event_type(dev, type))
-               return 1;
+               return -1;
 
        max = type_to_mask(dev, type, &mask);
 
        if (code > max)
-               return 1;
+               return -1;
 
        set_bit(mask, code);
 
@@ -835,12 +835,12 @@ libevdev_disable_event_code(struct libevdev *dev, unsigned int type, unsigned in
        unsigned long *mask;
 
        if (type > EV_MAX)
-               return 1;
+               return -1;
 
        max = type_to_mask(dev, type, &mask);
 
        if (code > max)
-               return 1;
+               return -1;
 
        clear_bit(mask, code);