ARM: dts: qcom: msm8660: override nodes by label
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 10 Aug 2022 08:05:15 +0000 (11:05 +0300)
committerBjorn Andersson <andersson@kernel.org>
Mon, 29 Aug 2022 21:46:45 +0000 (16:46 -0500)
Using node paths to extend or override a device tree node is error
prone.  If there was a typo error, a new node will be created instead of
extending the existing node.  This will lead to run-time errors that
could be hard to detect.

A mistyped label on the other hand, will cause a dtc compile error
(during build time).  This also reduces the indentation making the code
easier to read.

The pre/post DTBS are the same.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20220810080516.166866-3-krzysztof.kozlowski@linaro.org
arch/arm/boot/dts/qcom-msm8660-surf.dts

index 414280d..63b8f42 100644 (file)
        };
 
        soc {
-               gsbi@19c00000 {
-                       status = "okay";
-                       qcom,mode = <GSBI_PROT_I2C_UART>;
-                       serial@19c40000 {
-                               status = "okay";
-                       };
-               };
-
                /* Temporary fixed regulator */
                vsdcc_fixed: vsdcc-regulator {
                        compatible = "regulator-fixed";
                        regulator-max-microvolt = <2700000>;
                        regulator-always-on;
                };
+       };
+};
 
-               amba {
-                       /* eMMC */
-                       sdcc1: mmc@12400000 {
-                               status = "okay";
-                               vmmc-supply = <&vsdcc_fixed>;
-                       };
+&gsbi12 {
+       qcom,mode = <GSBI_PROT_I2C_UART>;
+       status = "okay";
+};
 
-                       /* External micro SD card */
-                       sdcc3: mmc@12180000 {
-                               status = "okay";
-                               vmmc-supply = <&vsdcc_fixed>;
-                       };
-               };
-       };
+&gsbi12_serial {
+       status = "okay";
 };
 
 &pm8058 {
                keypad,num-columns = <5>;
        };
 };
+
+/* eMMC */
+&sdcc1 {
+       vmmc-supply = <&vsdcc_fixed>;
+       status = "okay";
+};
+
+/* External micro SD card */
+&sdcc3 {
+       vmmc-supply = <&vsdcc_fixed>;
+       status = "okay";
+};