clocksource/drivers/ingenic: Fix section mismatch
authorDaniel Lezcano <daniel.lezcano@linaro.org>
Wed, 25 Nov 2020 10:23:45 +0000 (11:23 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 3 Dec 2020 18:16:26 +0000 (19:16 +0100)
The function ingenic_tcu_get_clock() is annotated for the __init
section but it is actually called from the online cpu callback.

That will lead to a crash if a CPU is hotplugged after boot time.

Remove the __init annotation for the ingenic_tcu_get_clock()
function.

Fixes: f19d838d08fc (clocksource/drivers/ingenic: Add high resolution timer support for SMP/SMT)
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Paul Cercueil <paul@crapouillou.net>
Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
Link: https://lore.kernel.org/r/20201125102346.1816310-1-daniel.lezcano@linaro.org
drivers/clocksource/ingenic-timer.c

index 58fd918..905fd6b 100644 (file)
@@ -127,7 +127,7 @@ static irqreturn_t ingenic_tcu_cevt_cb(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
-static struct clk * __init ingenic_tcu_get_clock(struct device_node *np, int id)
+static struct clk *ingenic_tcu_get_clock(struct device_node *np, int id)
 {
        struct of_phandle_args args;