basesink: fix buffer leaks if preroll failed
authorJason Lin <shangchieh@realtek.com>
Thu, 13 Jul 2017 13:52:34 +0000 (21:52 +0800)
committerMatthew Waters <matthew@centricular.com>
Fri, 14 Jul 2017 04:02:52 +0000 (14:02 +1000)
buffer is not unreferened if preroll failed

:Detailed Notes:
- Problem : video freeze when switching from pause to 1/2-FF repeatedly
- RootCause : buffer leaks in basesink
- Solution : unref the buffer if prerolled failed

:Testing Preformed:
How to Test :
pause -> 1/2 FF -> resume -> pause -> 1/2 FF ...

https://bugzilla.gnome.org/show_bug.cgi?id=784932

libs/gst/base/gstbasesink.c

index ea90e76..53cb636 100644 (file)
@@ -3657,6 +3657,7 @@ dropped:
 preroll_failed:
   {
     GST_DEBUG_OBJECT (basesink, "preroll failed: %s", gst_flow_get_name (ret));
+    gst_mini_object_unref (GST_MINI_OBJECT_CAST (obj));
     return ret;
   }
 }