media: ov13858: Add implementation for events
authorRicardo Ribalda <ribalda@chromium.org>
Wed, 6 Oct 2021 22:26:24 +0000 (00:26 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fri, 8 Oct 2021 11:42:07 +0000 (13:42 +0200)
Use v4l2 control API helpers to support the events.

Fixes v4l2-compliance:

test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ov13858.c

index 7fc70af..b4d22f5 100644 (file)
@@ -7,6 +7,7 @@
 #include <linux/pm_runtime.h>
 #include <media/v4l2-ctrls.h>
 #include <media/v4l2-device.h>
+#include <media/v4l2-event.h>
 #include <media/v4l2-fwnode.h>
 
 #define OV13858_REG_VALUE_08BIT                1
@@ -1553,6 +1554,12 @@ static int ov13858_identify_module(struct ov13858 *ov13858)
        return 0;
 }
 
+static const struct v4l2_subdev_core_ops ov13858_core_ops = {
+       .log_status = v4l2_ctrl_subdev_log_status,
+       .subscribe_event = v4l2_ctrl_subdev_subscribe_event,
+       .unsubscribe_event = v4l2_event_subdev_unsubscribe,
+};
+
 static const struct v4l2_subdev_video_ops ov13858_video_ops = {
        .s_stream = ov13858_set_stream,
 };
@@ -1569,6 +1576,7 @@ static const struct v4l2_subdev_sensor_ops ov13858_sensor_ops = {
 };
 
 static const struct v4l2_subdev_ops ov13858_subdev_ops = {
+       .core = &ov13858_core_ops,
        .video = &ov13858_video_ops,
        .pad = &ov13858_pad_ops,
        .sensor = &ov13858_sensor_ops,
@@ -1724,7 +1732,8 @@ static int ov13858_probe(struct i2c_client *client,
 
        /* Initialize subdev */
        ov13858->sd.internal_ops = &ov13858_internal_ops;
-       ov13858->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
+       ov13858->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE |
+                            V4L2_SUBDEV_FL_HAS_EVENTS;
        ov13858->sd.entity.ops = &ov13858_subdev_entity_ops;
        ov13858->sd.entity.function = MEDIA_ENT_F_CAM_SENSOR;