[Ada] Avoid building malformed component constraints
authorSteve Baird <baird@adacore.com>
Mon, 6 Dec 2021 21:42:51 +0000 (13:42 -0800)
committerPierre-Marie de Rodat <derodat@adacore.com>
Thu, 6 Jan 2022 17:11:36 +0000 (17:11 +0000)
gcc/ada/

* sem_util.adb (Build_Discriminant_Reference): In the unexpected
case where we previously would fail an assertion, we instead
revert to the old behavior.

gcc/ada/sem_util.adb

index 2bc3c95..e07e487 100644 (file)
@@ -2107,11 +2107,7 @@ package body Sem_Util is
       --  Start of processing for Build_Discriminant_Reference
 
       begin
-         if Obj_Is_Good_Prefix then
-            return Make_Selected_Component (Loc,
-                     Prefix => Copy_And_Maybe_Dereference (Obj),
-                     Selector_Name => New_Occurrence_Of (Discrim, Loc));
-         else
+         if not Obj_Is_Good_Prefix then
             --  If the given discriminant is not a component of the given
             --  object, then try the enclosing object.
 
@@ -2128,10 +2124,15 @@ package body Sem_Util is
                         (Discrim_Name => Discrim_Name,
                          Obj          => Name (Parent (Entity (Obj))));
             else
-               pragma Assert (False);
-               raise Program_Error;
+               --  We are in some unexpected case here, so revert to the
+               --  old behavior (by falling through to it).
+               null;
             end if;
          end if;
+
+         return Make_Selected_Component (Loc,
+                  Prefix => Copy_And_Maybe_Dereference (Obj),
+                  Selector_Name => New_Occurrence_Of (Discrim, Loc));
       end Build_Discriminant_Reference;
 
       ------------------------------------