Temporarily revert just Multiply to see if that's the source of NEON diffs.
authormtklein <mtklein@chromium.org>
Thu, 14 May 2015 16:17:08 +0000 (09:17 -0700)
committerCommit bot <commit-bot@chromium.org>
Thu, 14 May 2015 16:17:09 +0000 (09:17 -0700)
Local testing is confusing and inconclusive.  Pulling out the big guns.

BUG=skia:

Review URL: https://codereview.chromium.org/1129293005

src/core/SkXfermode.cpp

index 2abe55a..28f247b 100644 (file)
@@ -1493,7 +1493,9 @@ SkXfermode* create_mode(int iMode) {
         case SkXfermode::kPlus_Mode:     return SkT4pxXfermode<Plus4f>::Create(rec);
         case SkXfermode::kModulate_Mode: return SkT4pxXfermode<Modulate4f>::Create(rec);
         case SkXfermode::kScreen_Mode:   return SkT4pxXfermode<Screen4f>::Create(rec);
-        case SkXfermode::kMultiply_Mode: return SkT4pxXfermode<Multiply4f>::Create(rec);
+        // Temporarily reverted to see if this is what's causing NEON diffs.
+        // If not, will try Xor, DstATop, then SrcATop in that order.
+        //case SkXfermode::kMultiply_Mode: return SkT4pxXfermode<Multiply4f>::Create(rec);
         default: break;
     }
 #endif