i2c: mediatek: remove redundant null check
authorXu Wang <vulab@iscas.ac.cn>
Wed, 30 Sep 2020 08:42:33 +0000 (08:42 +0000)
committerWolfram Sang <wsa@kernel.org>
Tue, 1 Mar 2022 15:22:23 +0000 (16:22 +0100)
Because clk_disable_unprepare already checked NULL clock parameter,
so the additional checks are unnecessary, just remove it

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-mt65xx.c

index 682293e..5bf7f96 100644 (file)
@@ -476,8 +476,7 @@ static int mtk_i2c_clock_enable(struct mtk_i2c *i2c)
        return 0;
 
 err_arb:
-       if (i2c->have_pmic)
-               clk_disable_unprepare(i2c->clk_pmic);
+       clk_disable_unprepare(i2c->clk_pmic);
 err_pmic:
        clk_disable_unprepare(i2c->clk_main);
 err_main:
@@ -488,11 +487,9 @@ err_main:
 
 static void mtk_i2c_clock_disable(struct mtk_i2c *i2c)
 {
-       if (i2c->clk_arb)
-               clk_disable_unprepare(i2c->clk_arb);
+       clk_disable_unprepare(i2c->clk_arb);
 
-       if (i2c->have_pmic)
-               clk_disable_unprepare(i2c->clk_pmic);
+       clk_disable_unprepare(i2c->clk_pmic);
 
        clk_disable_unprepare(i2c->clk_main);
        clk_disable_unprepare(i2c->clk_dma);