Bluetooth: AMP contollers do not support the legacy ioctls
authorMarcel Holtmann <marcel@holtmann.org>
Thu, 10 Oct 2013 17:02:08 +0000 (10:02 -0700)
committerJohan Hedberg <johan.hedberg@intel.com>
Thu, 10 Oct 2013 20:08:37 +0000 (22:08 +0200)
The legacy ioctls for device specific commands including inquiry are
not support by AMP controllers. So just reject them right away instead
of trying to send the HCI command and wait for failure from the
actual hardware.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
net/bluetooth/hci_core.c
net/bluetooth/hci_sock.c

index 0c636ba..593b4ef 100644 (file)
@@ -1048,6 +1048,11 @@ int hci_inquiry(void __user *arg)
                goto done;
        }
 
+       if (hdev->dev_type != HCI_BREDR) {
+               err = -EOPNOTSUPP;
+               goto done;
+       }
+
        if (!test_bit(HCI_BREDR_ENABLED, &hdev->dev_flags)) {
                err = -EOPNOTSUPP;
                goto done;
@@ -1533,6 +1538,11 @@ int hci_dev_cmd(unsigned int cmd, void __user *arg)
                goto done;
        }
 
+       if (hdev->dev_type != HCI_BREDR) {
+               err = -EOPNOTSUPP;
+               goto done;
+       }
+
        if (!test_bit(HCI_BREDR_ENABLED, &hdev->dev_flags)) {
                err = -EOPNOTSUPP;
                goto done;
index 5798861..5b2d3f3 100644 (file)
@@ -518,6 +518,9 @@ static int hci_sock_bound_ioctl(struct sock *sk, unsigned int cmd,
        if (test_bit(HCI_USER_CHANNEL, &hdev->dev_flags))
                return -EBUSY;
 
+       if (hdev->dev_type != HCI_BREDR)
+               return -EOPNOTSUPP;
+
        switch (cmd) {
        case HCISETRAW:
                if (!capable(CAP_NET_ADMIN))